Refactor LLMProvider to use MODEL_PROVIDER_MAP for model-provider map… #1280
+52
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ping # what changed - Removed the old modelToProviderMap and replaced it with the new MODEL_PROVIDER_MAP for better maintainability and clarity. - Updated the LLMProvider class to utilize the new mapping, ensuring consistent handling of model names and providers. # test plan - Ensure existing functionality remains intact by running all relevant tests and verifying no regressions occur.
🦋 Changeset detectedLatest commit: a7e65c1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Greptile Summary
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant LLMProvider
participant MODEL_PROVIDER_MAP
participant Client
User->>LLMProvider: "getClient(modelName)"
LLMProvider->>LLMProvider: "Check if modelName contains '/'"
alt AISDK model (contains '/')
LLMProvider->>LLMProvider: "Parse provider and model"
LLMProvider->>Client: "Return AISdkClient"
else Known model
LLMProvider->>MODEL_PROVIDER_MAP: "Lookup modelName as KnownModel"
MODEL_PROVIDER_MAP-->>LLMProvider: "Return provider"
LLMProvider->>Client: "Return provider-specific client (OpenAI/Anthropic/etc)"
end
Client-->>User: "LLMClient instance"
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
2 files reviewed, no comments
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ping
what changed
test plan
why
what changed
test plan